[webkit-reviews] review denied: [Bug 47660] SVGFEConvolveMatrixElement doesn't support dynamic invalidation : [Attachment 70723] Patch for feConvolveMatrix DOM attributes

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Renata Hodovan
<reni at inf.u-szeged.hu>'s request for review:
Bug 47660: SVGFEConvolveMatrixElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=47660

Attachment 70723: Patch for feConvolveMatrix DOM attributes
https://bugs.webkit.org/attachment.cgi?id=70723&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70723&action=review

> WebCore/svg/SVGFEConvolveMatrixElement.idl:54
> +	   void setKernelUnitLength(in float kernelUnitLengthX, in float
kernelUnitLengthY);
> +	   void setOrder(in unsigned long orderX, in unsigned long orderY);

Why are you adding these, are they in the specification?
Regardless, they're not covered by any layout tests. This needs to be fixed.