[webkit-reviews] review denied: [Bug 47608] Add !SINGLE_THREADED guard. : [Attachment 70639] Patch. Add !SINGLE_THREADED guard.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 13 22:44:49 PDT 2010


David Levin <levin at chromium.org> has denied Hyung Song
<beergun at company100.net>'s request for review:
Bug 47608: Add !SINGLE_THREADED guard.
https://bugs.webkit.org/show_bug.cgi?id=47608

Attachment 70639: Patch. Add !SINGLE_THREADED guard.
https://bugs.webkit.org/attachment.cgi?id=70639&action=review

------- Additional Comments from David Levin <levin at chromium.org>
It seems like it would be better to implement a mutex whose tryLock returns
true rather than putting these if'defs throughout the code.

You could also have a "yield" that does nothing.


More information about the webkit-reviews mailing list