[webkit-reviews] review denied: [Bug 47647] commit-queue should not fail patches due to flaky tests : [Attachment 70704] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 47647: commit-queue should not fail patches due to flaky tests
https://bugs.webkit.org/show_bug.cgi?id=47647

Attachment 70704: Patch
https://bugs.webkit.org/attachment.cgi?id=70704&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70704&action=review

I like the idea, but the static information about where to find results.html
isn't right.

> WebKitTools/Scripts/webkitpy/common/net/layouttestresults.py:87
> +	   if not results_path:
> +	       results_path = "/tmp/layout-test-results/results.html"

This doesn't seem right.

> WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:124
> +	   results = LayoutTestResults.results_from_local_run()

so static.  in this beautiful non-static class

I think this actually reads the disk during the commitqueuetask unit tests. 
Sad face.

> WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:144
> +	   # The CommitQueue Command object knows its name and how to
> +	   # cc the right watchers.

This comment seems unnecessary.