[webkit-reviews] review granted: [Bug 45716] [BREWMP] Port unicode : [Attachment 70690] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 13 17:44:55 PDT 2010


Kent Tamura <tkent at chromium.org> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 45716: [BREWMP] Port unicode
https://bugs.webkit.org/show_bug.cgi?id=45716

Attachment 70690: Patch
https://bugs.webkit.org/attachment.cgi?id=70690&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70690&action=review

> JavaScriptCore/wtf/unicode/brew/UnicodeBrew.cpp:94
> +	   remainingCharacters += sourceEnd - sourceIterator;

+= looks curious here.
  int remainingCharacters = sourceIterator < sourceEnd ? sourceEnd -
sourceIterator : 0;
would be better.


More information about the webkit-reviews mailing list