[webkit-reviews] review granted: [Bug 47121] need way to measure size of JITed ARM code : [Attachment 70006] Fix style
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 13 17:22:36 PDT 2010
Darin Adler <darin at apple.com> has granted David Goodwin
<david_goodwin at apple.com>'s request for review:
Bug 47121: need way to measure size of JITed ARM code
https://bugs.webkit.org/show_bug.cgi?id=47121
Attachment 70006: Fix style
https://bugs.webkit.org/attachment.cgi?id=70006&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70006&action=review
> JavaScriptCore/assembler/LinkBuffer.h:269
> + dumpLinkStats(m_code, initialSize, m_size);
Why abbreviate to “stats”?
> JavaScriptCore/assembler/LinkBuffer.h:292
> + static unsigned totalInitialSize = 0, totalFinalSize = 0;
We normally declare these things on separate lines.
More information about the webkit-reviews
mailing list