[webkit-reviews] review granted: [Bug 47633] [chromium] compile TestNetscapePlugIn on Chromium mac : [Attachment 70680] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 13 16:55:39 PDT 2010
Kent Tamura <tkent at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 47633: [chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633
Attachment 70680: Patch
https://bugs.webkit.org/attachment.cgi?id=70680&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70680&action=review
> WebKitTools/DumpRenderTree/DumpRenderTree.gypi:47
> + 'test_plugin_files': [
nit: Our gyp sorting rule is probably ASCII order or case-insensitive
alphabetical order. The order of TestObject.h -> main.cpp -> Tests/ looks not
good.
More information about the webkit-reviews
mailing list