[webkit-reviews] review granted: [Bug 47631] Draw the find overlay holes : [Attachment 70677] Patch

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 47631: Draw the find overlay holes
https://bugs.webkit.org/show_bug.cgi?id=47631

Attachment 70677: Patch
https://bugs.webkit.org/attachment.cgi?id=70677&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70677&action=review

See my comment above about where to put the constant definitions. I don't have
a horse in that race, though.

> WebKit2/ChangeLog:10
> +	   Move the color component constants into overlayBackgroundColor.

I'm not sure what the style guidelines say about this. I'm used to putting all
the static consts at the top of the file. It seems odd to put the color ones
inside overlayBackgroundColor, but not put the shadow ones inside drawRect.