[webkit-reviews] review granted: [Bug 47530] IndexedDB should fire some errors synchronously : [Attachment 70622] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 47530: IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530

Attachment 70622: Patch
https://bugs.webkit.org/attachment.cgi?id=70622&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70622&action=review

> LayoutTests/storage/indexeddb/objectstore-basics.html:64
>	   shouldBeNull("index"); // Returning null is wrong, but less wrong
than returning an actual object!

Does this null check still make sense if we already know we're failing?  It's
not entirely clear to me.

> LayoutTests/storage/indexeddb/objectstore-basics.html:87
> +	   shouldBeNull("index"); // Returning null is wrong, but less wrong
than returning an actual object!

Same as above.