[webkit-reviews] review denied: [Bug 47542] Web Inspector: need a breakpoint for the timer events. : [Attachment 70600] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 47542: Web Inspector: need a breakpoint for the timer events.
https://bugs.webkit.org/show_bug.cgi?id=47542

Attachment 70600: Patch.
https://bugs.webkit.org/attachment.cgi?id=70600&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70600&action=review

> WebCore/inspector/InspectorInstrumentation.cpp:46
> +static const char* const timeoutEventName = "extended.timeout";

"timeout" is a bad name for the event. timerFire (localized "Timer fire" in UI)
sounds more user-friendly.
Also, encoding extended event names using dot-separated strings is fragile:
there is no guarantee event will not have similar name. So you should either
create a pair here or be more creative about encoding the event names.

> WebCore/inspector/front-end/BreakpointManager.js:508
> +	   if (this._eventName.search(prefix) !== 0)

Nit: use indexOf instead of regex search.

> WebCore/inspector/front-end/BreakpointsSidebarPane.js:251
> +	       "HTML frame/object": ["load", "error", "resize", "scroll",
"extended.timeout"]

I think you are adding confusion here: timeout is not a real event. I think we
should we have a separate category for it. It might have all timer-related
breaks such as setTimeout, clearTimeout and timerFire event.