[webkit-reviews] review granted: [Bug 37176] Canvas: radialGradient with negative radius should throw exception : [Attachment 68633] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 13 02:00:38 PDT 2010
Dirk Schulze <krit at webkit.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 37176: Canvas: radialGradient with negative radius should throw exception
https://bugs.webkit.org/show_bug.cgi?id=37176
Attachment 68633: Patch
https://bugs.webkit.org/attachment.cgi?id=68633&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68633&action=review
r=me
> WebCore/html/canvas/CanvasRenderingContext2D.cpp:1458
> + if (r0 < 0 || r1 < 0) {
> + ec = INDEX_SIZE_ERR;
> + return 0;
> + }
Add a newline before and after the condition.
More information about the webkit-reviews
mailing list