[webkit-reviews] review denied: [Bug 47572] [Chromium] Leak in WebCore::createFontCustomPlatformData : [Attachment 70584] A quick fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 13 00:07:09 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 47572: [Chromium] Leak in WebCore::createFontCustomPlatformData
https://bugs.webkit.org/show_bug.cgi?id=47572

Attachment 70584: A quick fix
https://bugs.webkit.org/attachment.cgi?id=70584&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
I would prefer to have Chrome call WebCache::clear() when in valgrind mode.
I don't think the release product should need to clear the WebCore cache
at renderer shutdown time.  It is costly to walk the cache and bring all of
those objects into memory just to free them.  This will make it slower to
close tabs, etc.


More information about the webkit-reviews mailing list