[webkit-reviews] review granted: [Bug 46016] [chromium] There should be an API for showing an external popup that does not require creation of a WebWidget : [Attachment 70538] Adding an static method to WebView to set whether to use external popups or not.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 46016: [chromium] There should be an API for showing an external popup that
does not require creation of a WebWidget
https://bugs.webkit.org/show_bug.cgi?id=46016

Attachment 70538: Adding an static method to WebView to set whether to use
external popups or not.
https://bugs.webkit.org/attachment.cgi?id=70538&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70538&action=review

> WebKit/chromium/public/WebView.h:311
> +    // Popup menu ----------------------------------------------------------


nit: please preserve the two lines of whitespace above a section divider
comment.

> WebKit/chromium/src/ExternalPopupMenu.cpp:41
> +

nit: I recommend adding a 'using namespace WebCore' here.  then kill off the
WebCore:: prefixes down below.

otherwise, R=me