[webkit-reviews] review granted: [Bug 47559] Start fleshing out find page overlays : [Attachment 70568] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 12 16:07:20 PDT 2010
Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 47559: Start fleshing out find page overlays
https://bugs.webkit.org/show_bug.cgi?id=47559
Attachment 70568: Patch
https://bugs.webkit.org/attachment.cgi?id=70568&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70568&action=review
> WebKit2/WebProcess/WebPage/FindController.cpp:72
> + }
The braces are not necessary here.
> WebKit2/WebProcess/WebPage/FindController.cpp:84
> + ASSERT(shouldShowOverlay);
This ASSERT is not adding anything.
More information about the webkit-reviews
mailing list