[webkit-reviews] review denied: [Bug 47391] [chromium] fix scrolling of noncomposited iframes within composited document : [Attachment 70190] Issue invalidate in the right coordinate system. Oops.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 14:57:11 PDT 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Nat Duca
<nduca at chromium.org>'s request for review:
Bug 47391: [chromium] fix scrolling of noncomposited iframes within composited
document
https://bugs.webkit.org/show_bug.cgi?id=47391

Attachment 70190: Issue invalidate in the right coordinate system. Oops.
https://bugs.webkit.org/attachment.cgi?id=70190&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
On Mac, redrawing of composited iframes on scrolling happens via the swizzled
setNeedsDisplayInRect: method in WebTMLView.mm. It is broken on Windows and in
WebKit2, so something like this patch is needed.

However, this patch adds an invalidate for every scroll, not just scrolls of
iframes in compositing layers. We certainly don't want that.


More information about the webkit-reviews mailing list