[webkit-reviews] review granted: [Bug 47550] For WebKit plug-ins, beforeload can be called recursively (esp. with AdBlock style extensions) : [Attachment 70554] proposed patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 47550: For WebKit plug-ins, beforeload can be called recursively (esp. with
AdBlock style extensions)
https://bugs.webkit.org/show_bug.cgi?id=47550

Attachment 70554: proposed patch
https://bugs.webkit.org/attachment.cgi?id=70554&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70554&action=review

> WebCore/html/HTMLPlugInElement.cpp:108
> +    if (m_inBeforeLoadEventHandler) {
> +	   // The plug-in hasn't loaded yet, and it makes no sense to try to
load if beforeload handler happened to touch the plug-in element.
> +	   // That would recursively call beforeload for the same element.
> +	   return false;
> +    }

This should return 0, not return false.