[webkit-reviews] review denied: [Bug 45750] Move backing-store contents on slow scrolls : [Attachment 69382] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied João Paulo Rechi Vita
<jprvita at profusion.mobi>'s request for review:
Bug 45750: Move backing-store contents on slow scrolls
https://bugs.webkit.org/show_bug.cgi?id=45750

Attachment 69382: Patch
https://bugs.webkit.org/attachment.cgi?id=69382&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
We discussed this some on IRC, but basically if the slow scroll method is
called it specifically means that WebCore has detected that it is not safe to
just move the pixels.  The test case did actually work still with this patch,
and that baffles me (it makes me think there may be some HostWindow
mis-implementation leading to a lucky extra repaint).  The fact that you need
this change makes me think maybe your canBlitOnScroll state is corrupted or not
set up properly.

I'd love to see an actual test case that gets faster with this patch.  That
would be really helpful for understanding what problem this patch is trying to
solve.