[webkit-reviews] review denied: [Bug 47423] [chromium] Update WebBlobData to adapt to BlobData change in terms of handling string data item : [Attachment 70544] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jian Li
<jianli at chromium.org>'s request for review:
Bug 47423: [chromium] Update WebBlobData to adapt to BlobData change in terms
of handling string data item
https://bugs.webkit.org/show_bug.cgi?id=47423

Attachment 70544: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=70544&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70544&action=review

> WebKit/chromium/public/WebThreadSafeData.h:37
> +namespace WebCore { class RawData; }

where is RawData defined?  i cannot find it in the source tree.

> WebKit/chromium/public/WebThreadSafeData.h:84
> +    WebThreadSafeDataPrivate* m_private;

please take advantage of WebPrivatePtr<T>.  that is the new way of wrapping
a reference counted WebCore type.  see WebNode.h for example.