[webkit-reviews] review requested: [Bug 47506] Optimize String.prototype.replace on v8-regexp : [Attachment 70545] Updated patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 47506: Optimize String.prototype.replace on v8-regexp
https://bugs.webkit.org/show_bug.cgi?id=47506

Attachment 70545: Updated patch
https://bugs.webkit.org/attachment.cgi?id=70545&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
Changed the embedded assignments in the if statements to be independent and
include declarations.

Concerning comment #4, the impact of the copying of zero length strings is
measurable although I didn't break it out separately.  The
StringImpl::copyChars() actually result in a function call (not inlined).  The
zero length check before the call eliminates not only the call but a few other
instructions as well.