[webkit-reviews] review denied: [Bug 47486] WTR should accept relative paths : [Attachment 70505] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 47486: WTR should accept relative paths
https://bugs.webkit.org/show_bug.cgi?id=47486

Attachment 70505: Patch
https://bugs.webkit.org/attachment.cgi?id=70505&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70505&action=review

> WebKitTools/ChangeLog:11
> +	   * WebKitTestRunner/TestInvocation.cpp:
> +	   (WTR::createWKURL): Moved from StringFunctions.h since it is
> +	   used only here. Extend relative paths to absolute.

I don't think we need this move. WTR::createWKURL is a general function 
and not TestInvocation specific. Now only the TestInvocation.cpp uses it,
but it can be changed in the future.

> WebKitTools/WebKitTestRunner/TestInvocation.cpp:64
> +#if OS(WINDOWS)
> +    const char separator = '\\';
> +    bool isAbsolutePath = length >= 3 && pathOrURL[1] == ':' && pathOrURL[2]
== separator;
> +#else
> +    const char separator = '/';
> +    bool isAbsolutePath = pathOrURL[0] == separator;
> +#endif
> +

We don't need Windows case, because we run WTR inside CygWin
where the paths are similar to paths on Linux (/cygdrive/c/....)