[webkit-reviews] review granted: [Bug 47511] [Chromium] Add plumbing for synchronous indexedDB exceptions : [Attachment 70487] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 47511: [Chromium] Add plumbing for synchronous indexedDB exceptions
https://bugs.webkit.org/show_bug.cgi?id=47511

Attachment 70487: Patch
https://bugs.webkit.org/attachment.cgi?id=70487&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70487&action=review

r+ provided my comments/guesses are correct :)

> WebKit/chromium/public/WebExceptionCode.h:36
> +// This should match how exception code is defined in WebCore.

Nit: replace 'exception code' with 'ExceptionCode' so it's clear what this is
referring to?

> WebKit/chromium/public/WebIDBCursor.h:65
> +    virtual void update(const WebSerializedScriptValue& value,
WebIDBCallbacks* callbacks, WebExceptionCode&)
> +    {
> +	   update(value, callbacks);
> +    }
> +    virtual void update(const WebSerializedScriptValue& value,
WebIDBCallbacks* callbacks)
> +    {
> +	   WebExceptionCode ec = 0;
> +	   update(value, callbacks, ec);
> +    }

It appears that a bunch of these implementations are circular.	I'm assuming
that this code is unused and these are just to ensure the compiler doesn't give
unused variable warnings?

> WebKit/chromium/public/WebIDBCursor.h:89
> +    /*
> +    virtual void update(const WebSerializedScriptValue&, WebIDBCallbacks*,
WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
> +    virtual void continueFunction(const WebIDBKey&, WebIDBCallbacks*,
WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
> +    virtual void remove(WebIDBCallbacks*, WebExceptionCode&) {
WEBKIT_ASSERT_NOT_REACHED(); }
> +    */

Here and below:  Why are these commented out?  Are they going to replace the
implementations above when the FIXMEs are resolved?