[webkit-reviews] review granted: [Bug 47473] Use new WebThemeEngine api on chromium / linux to draw scrollbars. : [Attachment 70484] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 11 16:02:49 PDT 2010


Tony Chang <tony at chromium.org> has granted Dave Moore <davemoore at google.com>'s
request for review:
Bug 47473: Use new WebThemeEngine api on chromium / linux to draw scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=47473

Attachment 70484: Patch
https://bugs.webkit.org/attachment.cgi?id=70484&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70484&action=review

You'll probably have to roll WebKit/WebKit/chromium/DEPS to pick up your
chromium fixes.

Please watch the build.webkit.org DRT bots and the build.chromium.org
experimental bots when landing.

> WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:76
>      if (scrollbar->orientation() == HorizontalScrollbar) {

Sorry, you're right, this condition is needed.


More information about the webkit-reviews mailing list