[webkit-reviews] review denied: [Bug 47423] [chromium] Update WebBlobData to adapt to BlobData change in terms of handling string data item : [Attachment 70453] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jian Li
<jianli at chromium.org>'s request for review:
Bug 47423: [chromium] Update WebBlobData to adapt to BlobData change in terms
of handling string data item
https://bugs.webkit.org/show_bug.cgi?id=47423

Attachment 70453: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=70453&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70453&action=review

> WebKit/chromium/public/WebBlobData.h:51
> +	   WebDependentData data;

This scares me because you are putting a memory address into a data structure,
and relying on the guy who created the WebBlobData to keep the memory address
valid.	It would be much better to use WebData.

Why don't you change WebCore::BlobDataItem::data to be of type
RefPtr<SharedBuffer>
instead of CString?  Then, the conversion from WebData to RefPtr<SharedBuffer>
would be super cheap.