[webkit-reviews] review granted: [Bug 47439] Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal representation of a WebKit1 WebSerializedJSValue : [Attachment 70459] Adds the private API for creating a WebKit2 WebSerializedScriptValue from the internal representation of a WebKit1 WebSerializedJSValue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 11 13:39:00 PDT 2010


Darin Adler <darin at apple.com> has granted Jessie Berlin <jberlin at webkit.org>'s
request for review:
Bug 47439: Add Private API for creating a WebKit2 WebSerializedScriptValue from
the internal representation of a WebKit1 WebSerializedJSValue
https://bugs.webkit.org/show_bug.cgi?id=47439

Attachment 70459: Adds the private API for creating a WebKit2
WebSerializedScriptValue from the internal representation of a WebKit1
WebSerializedJSValue
https://bugs.webkit.org/attachment.cgi?id=70459&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70459&action=review

> WebKit2/Shared/API/c/WKSerializedScriptValue.cpp:47
> +    RefPtr<WebSerializedScriptValue> serializedValue =
WebSerializedScriptValue::create(reinterpret_cast<WebCore::SerializedScriptValu
e*>(internalRepresentation));

This can be a static_cast rather than a reinterpret_cast.


More information about the webkit-reviews mailing list