[webkit-reviews] review denied: [Bug 47384] ARMv7 JIT should generated conditional branches when possible : [Attachment 70449] more descriptive ChangeLog (now without tabs, sigh)

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied David Goodwin
<david_goodwin at apple.com>'s request for review:
Bug 47384: ARMv7 JIT should generated conditional branches when possible
https://bugs.webkit.org/show_bug.cgi?id=47384

Attachment 70449: more descriptive ChangeLog (now without tabs, sigh)
https://bugs.webkit.org/attachment.cgi?id=70449&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70449&action=review

I'm not really comfortable with the new jumptype naming schem -- could you
explain what patchable means?

you should also replace the a == 0 checks with !a

> JavaScriptCore/assembler/ARMv7Assembler.h:482
> +    enum JumpType { JumpFixed, JumpNoCondition, JumpCondition,
PatchableJumpNoCondition, PatchableJumpCondition, JumpTypeCount };
> +    enum JumpLinkType { LinkInvalid, LinkJumpT1, LinkJumpT2, LinkJumpT3,

I don't really get this naming scheme -- what's meant by patchable vs. non
patchable?