[webkit-reviews] review granted: [Bug 46052] SVG: Remove "create" methods and use port-specific "add" counterparts : [Attachment 70460] Proposed patch v8

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 46052: SVG: Remove "create" methods and use port-specific "add"
counterparts
https://bugs.webkit.org/show_bug.cgi?id=46052

Attachment 70460: Proposed patch v8
https://bugs.webkit.org/attachment.cgi?id=70460&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70460&action=review

> WebCore/platform/graphics/Path.cpp:117
> +    FloatSize radius = roundingRadii;

Use FloatSize radius(roundingRadii);

> WebCore/svg/SVGStyledTransformableElement.cpp:118
> +    ASSERT(path.isEmpty());
> +
> +    toPathData(path);

You're calling ASSERT(path.isEmpty()); in toPathData, no need to assert twice.

Please change this before landing. Great patch! r=me.