[webkit-reviews] review denied: [Bug 46052] SVG: Remove "create" methods and use port-specific "add" counterparts : [Attachment 70451] Proposed patch v7

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Andreas Kling
<kling at webkit.org>'s request for review:
Bug 46052: SVG: Remove "create" methods and use port-specific "add"
counterparts
https://bugs.webkit.org/show_bug.cgi?id=46052

Attachment 70451: Proposed patch v7
https://bugs.webkit.org/attachment.cgi?id=70451&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70451&action=review

Please add the path isEmpty assertion in toPathData, an let's find out why it
doesn't build on mac...

> WebCore/platform/graphics/Path.cpp:132
> +    moveTo(FloatPoint(rect.x() + dx, rect.y()));

Please cache rect.x() / y() / width() / height() in local variables.

> WebCore/platform/graphics/Path.cpp:162
> +    if (rect.width() < topLeftRadius.width() + topRightRadius.width()

Please cache rect.x() / y() / width() / height() in local variables.