[webkit-reviews] review granted: [Bug 47472] Convert editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js to use LayoutTestController::setEditingBehavior : [Attachment 70435] patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 11 07:48:28 PDT 2010
Andreas Kling <kling at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 47472: Convert
editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js to
use LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=47472
Attachment 70435: patch v1
https://bugs.webkit.org/attachment.cgi?id=70435&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70435&action=review
LGTM.
>
LayoutTests/editing/selection/script-tests/click-in-padding-with-multiple-line-
boxes.js:52
> // Later we could break this into two tests, one that tests each platform's
rules,
> // since this is supported as a setting in the Settings object, but for now,
we'll
> // just use separate expected results for Mac and other platforms.
Seems like this comment should be deleted now.
More information about the webkit-reviews
mailing list