[webkit-reviews] review granted: [Bug 47471] convert editing/selection/script-tests/click-in-margins-inside-editable-div.js to use LayoutTestController::setEditingBehavior : [Attachment 70425] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 11 06:31:33 PDT 2010


Andreas Kling <kling at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 47471: convert
editing/selection/script-tests/click-in-margins-inside-editable-div.js to use
LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=47471

Attachment 70425: patch v1
https://bugs.webkit.org/attachment.cgi?id=70425&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70425&action=review

> LayoutTests/ChangeLog:9
> +	   LayoutTestController::setEditingBehavior machinary. That way, all
platform specific editing behavior

s/machinary/machinery/

>
LayoutTests/editing/selection/script-tests/click-in-margins-inside-editable-div
.js:71
>  // Later we could break this into two tests, one that tests each platform's
rules,
>  // since this is supported as a setting in the Settings object, but for now
we'll
>  // just use separate expected results for Mac and other platforms.

Seems like this comment should be removed now.


More information about the webkit-reviews mailing list