[webkit-reviews] review granted: [Bug 47400] Support DirectoryEntry.removeRecursively for FileSystem API : [Attachment 70214] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 47400: Support DirectoryEntry.removeRecursively for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47400

Attachment 70214: Patch
https://bugs.webkit.org/attachment.cgi?id=70214&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70214&action=review

> WebCore/ChangeLog:8
> +	   Also disallows remove/removeRecursively on the root directory.

Is there a test for this one? if not, please add one.

> WebCore/fileapi/DOMFileSystemBase.cpp:128
> +	   return false;

This was only returning true before.

Please check that the caller is properly handling false.

> WebCore/fileapi/DirectoryEntry.h:61
> +    virtual void removeRecursively(PassRefPtr<VoidCallback> successCallback
= 0, PassRefPtr<ErrorCallback> errorCallback = 0) const;

pls remove virtual.

Also, "successCallback" is a useful name. Please keep it.

But "errorCallback" just repeats the type. Please remove this param name.

> WebCore/fileapi/DirectoryEntrySync.cpp:80
> +	   ec = INVALID_MODIFICATION_ERR;

As discussed add a return here.