[webkit-reviews] review granted: [Bug 39978] spellcheck="false" not respected in designMode : [Attachment 70375] Moved the change to HTMLBodyElement

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 39978: spellcheck="false" not respected in designMode
https://bugs.webkit.org/show_bug.cgi?id=39978

Attachment 70375: Moved the change to HTMLBodyElement
https://bugs.webkit.org/attachment.cgi?id=70375&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70375&action=review

> WebCore/html/HTMLBodyElement.h:38
> +    virtual bool supportsFocus() const;

I would have made this a private member function. When overriding a function
from a base class, the visibility does not need to match the base class. I
often favor a design where we make the derived class override with a private
function if we never expect to call that function directly on that derived
class. A call to the virtual function when the pointer is an HTMLBodyElement*
would usually indicate a programming mistake so it’s nice the compiler would
catch it.