[webkit-reviews] review denied: [Bug 47432] No longer ASSERT for LayerRenderer in VideoLayerChromium destructor : [Attachment 70329] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 10 12:24:59 PDT 2010


Adam Barth <abarth at webkit.org> has denied Victoria Kirst <vrk at google.com>'s
request for review:
Bug 47432: No longer ASSERT for LayerRenderer in VideoLayerChromium destructor
https://bugs.webkit.org/show_bug.cgi?id=47432

Attachment 70329: Patch
https://bugs.webkit.org/attachment.cgi?id=70329&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70329&action=review

Can we have an test that hits this assert (even periodically)?

> WebCore/ChangeLog:17
> -	   
> +

This change is spurious and will cause the automatic commit to fail.

> WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:191
> +    if (layerRenderer()) {

Prefer early return.


More information about the webkit-reviews mailing list