[webkit-reviews] review denied: [Bug 31718] Framework to show form validation message for invalid controls : [Attachment 58375] Patch (rev.9)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 10 11:21:09 PDT 2010


Adam Barth <abarth at webkit.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 31718: Framework to show form validation message for invalid controls
https://bugs.webkit.org/show_bug.cgi?id=31718

Attachment 58375: Patch (rev.9)
https://bugs.webkit.org/attachment.cgi?id=58375&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=58375&action=review

r- for crash.

> WebCore/html/HTMLFormControlElement.cpp:360
> +    page->chrome()->updateFormValidationMessage(this, message);

Doesn't this crash if page is null?


More information about the webkit-reviews mailing list