[webkit-reviews] review denied: [Bug 42248] [Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine) : [Attachment 70403] Fix GraphicsContextQt::drawLine with X11 paint engine (fifth edition, wuthout #if)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 10 08:08:41 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied review:
Bug 42248: [Qt] Hovering the mouse over links produce a trail of underlined
links (X11 paint engine)
https://bugs.webkit.org/show_bug.cgi?id=42248
Attachment 70403: Fix GraphicsContextQt::drawLine with X11 paint engine (fifth
edition, wuthout #if)
https://bugs.webkit.org/attachment.cgi?id=70403&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70403&action=review
> WebCore/platform/graphics/qt/GraphicsContextQt.cpp:845
> + // like bug https://bugs.webkit.org/show_bug.cgi?id=42248
> + QPainter* p = m_data->p();
Benjamin, asked you to keep the ifdef, but add it here just before the
QPainter, like #if defined(Q_WS_X11). Check his comment for more info. He even
showed the code.
More information about the webkit-reviews
mailing list