[webkit-reviews] review requested: [Bug 42248] [Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine) : [Attachment 70400] Fix GraphicsContextQt::drawLine with X11 paint engine (fifth edition, corrected)

[bugzilla-daemon at webkit.org]

Sergey A. Sukiyazov <sergey.sukiyazov at gmail.com> has asked  for review:
Bug 42248: [Qt] Hovering the mouse over links produce a trail of underlined
links (X11 paint engine)
https://bugs.webkit.org/show_bug.cgi?id=42248

Attachment 70400: Fix GraphicsContextQt::drawLine with X11 paint engine (fifth
edition, corrected)
https://bugs.webkit.org/attachment.cgi?id=70400&action=review

------- Additional Comments from Sergey A. Sukiyazov
<sergey.sukiyazov at gmail.com>
(In reply to comment #45)
> (From update of attachment 70397 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=70397&action=review
> 
> > WebCore/platform/graphics/qt/GraphicsContextQt.cpp:840
> > +#if !defined(Q_WS_X11)
> 
> This define seems a bit useless. It will always be defined anyway for MeeGo,
Maemo etc even if these platforms use raster or opengl
I changed condition to !(defined(Q_WS_X11) && defined(Q_OS_UNIX)) It's more
exactly? 

Even this condition was useless, then I check for garaphics engine is X11. If
graphics engine is raster or opengl then no changes will 
be made - the original behavior will be kept

> > WebCore/platform/graphics/qt/GraphicsContextQt.cpp:845
> > +	 IntPoint p1 = origin;
> > +	 IntPoint p2 = origin + IntSize(width, 0);
> 
> Why not startPoint, endPoint
It not fundamental, I made it.