[webkit-reviews] review denied: [Bug 47070] [Texmap] [Qt] Texture mapper initial implementation : [Attachment 70365] Patch 5: have QWebFrame render the layer it got from TextureMapper

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 47070: [Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Attachment 70365: Patch 5: have QWebFrame render the layer it got from
TextureMapper
https://bugs.webkit.org/attachment.cgi?id=70365&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70365&action=review

> WebKit/qt/Api/qwebframe.cpp:306
> +    // TextureMapper might use raw OpenGL some other backend. On raster this
doesn't have any effect anyway.

raw OpenGL some other... the english sounds a bit strange.

> WebKit/qt/Api/qwebframe.cpp:308
> +    painter->beginNativePainting();
> +    if (rootGraphicsLayer)

do we really need beginNative* if there is no rootGraphicsLayer?

> WebKit/qt/Api/qwebframe.cpp:310
> +    painter->endNativePainting();

I would like a newline after this, as it is a kind of grouping

> WebKit/qt/Api/qwebframe.cpp:360
> +#if USE(ACCELERATED_COMPOSITING) && USE(TEXTURE_MAPPER)

why doesn't texture mapper imply accel. compositing

> WebKit/qt/Api/qwebframe.cpp:361
> +	   if (rootGraphicsLayer ) {

remove space after rootGraphicsLayer