[webkit-reviews] review denied: [Bug 47070] [Texmap] [Qt] Texture mapper initial implementation : [Attachment 70362] Patch 2: stub for media layer implementation.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 47070: [Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Attachment 70362: Patch 2: stub for media layer implementation.
https://bugs.webkit.org/attachment.cgi?id=70362&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70362&action=review

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:620
> +    {
> +	   if (!videoItem)
> +	       return;
> +
> +    }

what is the difference?

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:625
> +	   m_client = client;
> +
> +    }

excessive newline

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:627
> +    virtual void paint(GraphicsContext* gc)

context, and not gc please

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:631
> +	       return;
> +	   QStyleOptionGraphicsItem opt;

I prefer newline after return

> WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:105
> +    virtual void acceleratedRenderingStateChanged() {}

needs a space in {}, thus { }