[webkit-reviews] review denied: [Bug 34539] Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a stub for NPN_GetAuthenticationInfo : [Attachment 70372] Implement NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo [Final #8]...

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Dawit A. <adawit at kde.org>'s request
for review:
Bug 34539: Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a
stub for NPN_GetAuthenticationInfo
https://bugs.webkit.org/show_bug.cgi?id=34539

Attachment 70372: Implement NPN_GetValueForURL and NPN_SetValueForURL and
NPN_GetAuthenticationInfo [Final #8]...
https://bugs.webkit.org/attachment.cgi?id=70372&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70372&action=review

r- for the ChangeLog issue, the rest is cosmetics.

> WebCore/ChangeLog:6
> +	   Fix compile error when bulding webkit's Qt port using the "--v8"
option.
> +	   https://bugs.webkit.org/show_bug.cgi?id=47455

Oops, looks like you have some extra ChangeLog lying around.

> WebCore/platform/network/qt/ProxyServerQt.cpp:47
> +    if (proxyFactory) {

if (!proxyFactory)
    return servers;

> WebKit2/WebProcess/Plugins/PluginView.cpp:847
> +    const NetworkingContext* netContext = frameLoader ?
frameLoader->networkingContext() : 0;
> +    Vector<ProxyServer> proxyServers = proxyServersForURL(KURL(KURL(),
urlString), netContext);

Nit: "netContext" -> "context"