[webkit-reviews] review denied: [Bug 47455] [Qt] Compile fails when building qtwebkit with the "--v8" option... : [Attachment 70366] Proposed patch to fix compile issue...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 9 13:20:43 PDT 2010


Andreas Kling <kling at webkit.org> has denied Dawit A. <adawit at kde.org>'s request
for review:
Bug 47455: [Qt] Compile fails when building qtwebkit with the "--v8" option...
https://bugs.webkit.org/show_bug.cgi?id=47455

Attachment 70366: Proposed patch to fix compile issue...
https://bugs.webkit.org/attachment.cgi?id=70366&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70366&action=review

> WebCore/platform/qt/PlatformBridge.h:80
>  class NPObject;
> +class NPP;

Snag this from ChromiumBridge.h instead:

typedef struct NPObject NPObject;
typedef struct _NPP NPP_t;
typedef NPP_t* NPP;


More information about the webkit-reviews mailing list