[webkit-reviews] review requested: [Bug 45982] Web Inspector: FileSystem integration : [Attachment 70330] patch2

[bugzilla-daemon at webkit.org]

Kavita Kanetkar <kkanetkar at chromium.org> has asked  for review:
Bug 45982: Web Inspector: FileSystem integration
https://bugs.webkit.org/show_bug.cgi?id=45982

Attachment 70330: patch2
https://bugs.webkit.org/attachment.cgi?id=70330&action=review

------- Additional Comments from Kavita Kanetkar <kkanetkar at chromium.org>
I lost all my detailed review comments since I didn't hit 'Publish'.
I have made most of the changes and added FIXME for a few where it required
more investigation: Such as moving didGetFileSystemPath callback to
FileSystemView.js.

Currently like other callbacks, inspector.js gets it which delegates to
panels.storage which then delegates to FileSystemView. 

Also direct binding of buttons to InspectorBackend.revealFolderInOS didn't
work, so I am keeping the indirection as-is.

Made all other changes in InspectorFileSystemAgent: Consolidated 2 get* and
didGet methods to 1 get*Async and didGet* which take in type as a parameter to
separate persistent/temporary filesystem.

Few questions: Added FIXME for icon. Currently I am using application-cache
icon.  Should I create one by myself and add it here?
Another question was for Pavel in regards to your review comment, " I don't see
modifier localizedStrings.js file in this change set"
Where is the place I need to add it?

Thanks for the review!