[webkit-reviews] review denied: [Bug 47384] ARMv7 JIT should generated conditional branches when possible : [Attachment 70170] patch to use conditional branches when possible
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 8 18:10:21 PDT 2010
Oliver Hunt <oliver at apple.com> has denied David Goodwin
<david_goodwin at apple.com>'s request for review:
Bug 47384: ARMv7 JIT should generated conditional branches when possible
https://bugs.webkit.org/show_bug.cgi?id=47384
Attachment 70170: patch to use conditional branches when possible
https://bugs.webkit.org/attachment.cgi?id=70170&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70170&action=review
You need a more detailed changelog but other than that this looks good
> JavaScriptCore/ChangeLog:7
> +
You should have a description of what you're changing in a patch this size.
More information about the webkit-reviews
mailing list