[webkit-reviews] review granted: [Bug 47422] DOMWindow constructor directly callable : [Attachment 70323] Patch with additional tests fixes

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 47422: DOMWindow constructor directly callable
https://bugs.webkit.org/show_bug.cgi?id=47422

Attachment 70323: Patch with additional tests fixes
https://bugs.webkit.org/attachment.cgi?id=70323&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70323&action=review

Looks like we have good test coverage of this. Great fix.

> WebCore/WebCore.xcodeproj/project.pbxproj:-21153
> -			developmentRegion = English;

You are using the old Xcode?

> WebCore/bindings/scripts/CodeGeneratorJS.pm:2851
> -    push(@$outputArray, "	putDirect(exec->propertyNames().prototype,
${protoClassName}::self(exec, globalObject), DontDelete | ReadOnly);\n");
> +    if ($interfaceName eq "DOMWindow") {
> +	   push(@$outputArray, "    putDirect(exec->propertyNames().prototype,
globalObject->prototype(), DontDelete | ReadOnly);\n");
> +    } else {
> +	   push(@$outputArray, "    putDirect(exec->propertyNames().prototype,
${protoClassName}::self(exec, globalObject), DontDelete | ReadOnly);\n");
> +    }

Seems like it would be slightly cleaner to just use a variable for the
prototype expression. But I think this is OK as-is.