[webkit-reviews] review denied: [Bug 47422] DOMWindow constructor directly callable : [Attachment 70296] Patch to add DOMWindow constructor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 15:23:40 PDT 2010


Oliver Hunt <oliver at apple.com> has denied Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 47422: DOMWindow constructor directly callable
https://bugs.webkit.org/show_bug.cgi?id=47422

Attachment 70296: Patch to add DOMWindow constructor
https://bugs.webkit.org/attachment.cgi?id=70296&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70296&action=review

Code changes look sane, just not 100% happy with the .constructor test case.

> LayoutTests/fast/dom/Window/window-constructor-expected.txt:1
> +FAIL: Timed out waiting for notifyDone to be called

This indicates that you're not calling notifyDone() when the test finishes --
but is it really necessary for this test to be an onload?


More information about the webkit-reviews mailing list