[webkit-reviews] review denied: [Bug 47430] REGRESSION (r66599): Crash when using CSS content and -webkit-mask-box-image properties containing cached images. : [Attachment 70290] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 14:40:41 PDT 2010


Darin Adler <darin at apple.com> has denied  review:
Bug 47430: REGRESSION (r66599): Crash when using CSS content and
-webkit-mask-box-image properties containing cached images.
https://bugs.webkit.org/show_bug.cgi?id=47430

Attachment 70290: Patch
https://bugs.webkit.org/attachment.cgi?id=70290&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70290&action=review

> WebCore/rendering/RenderImage.cpp:126
> +    if (!m_imageResource)
> +	   return;

This is returning too early. We want to call through to
RenderReplaced::imageChanged even if m_imageResource is 0.


More information about the webkit-reviews mailing list