[webkit-reviews] review granted: [Bug 34397] Screen.availLeft should be signed : [Attachment 70278] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 34397: Screen.availLeft should be signed
https://bugs.webkit.org/show_bug.cgi?id=34397

Attachment 70278: Patch
https://bugs.webkit.org/attachment.cgi?id=70278&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70278&action=review

r=me

> WebCore/manual-tests/screen-availLeft.html:5
> +    <script type="text/javascript" charset="utf-8">

Charset is useless for inline scripts. But it's fine to land as is to make sure
it's not causing a crash somewhere.

> WebCore/manual-tests/screen-availLeft.html:11
> +	   function log(s)
> +	   {
> +	       var output = document.getElementById('output');
> +	       output.innerHTML += s + "<br>";
> +	   }

That's a lot of code for one lag() call.