[webkit-reviews] review granted: [Bug 47389] IndexedDB does not have a quota mechanism. : [Attachment 70272] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 47389: IndexedDB does not have a quota mechanism.
https://bugs.webkit.org/show_bug.cgi?id=47389

Attachment 70272: Patch
https://bugs.webkit.org/attachment.cgi?id=70272&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70272&action=review

r=me

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:303
> +    if (!insert.prepare()) {

compare against the constants

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:311
> +    if (!insert.step()) {

compare against the constants

> WebCore/storage/IDBObjectStoreBackendImpl.h:86
> +    static void putInternal(ScriptExecutionContext*,
PassRefPtr<IDBObjectStoreBackendImpl>, PassRefPtr<SerializedScriptValue> value,
PassRefPtr<IDBKey> key, bool addOnly, PassRefPtr<IDBCallbacks>,
PassRefPtr<IDBTransactionBackendInterface> transaction);

don't need the word transaction