[webkit-reviews] review denied: [Bug 47382] Blob / BlobBuilder can be put into bad state with wild integers and strings, due to integer overflows : [Attachment 70178] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Chris Evans <cevans at google.com>'s
request for review:
Bug 47382: Blob / BlobBuilder can be put into bad state with wild integers and
strings, due to integer overflows
https://bugs.webkit.org/show_bug.cgi?id=47382

Attachment 70178: Patch
https://bugs.webkit.org/attachment.cgi?id=70178&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70178&action=review

> WebCore/ChangeLog:5
> +	   https://bugs.webkit.org/show_bug.cgi?id=47382

Normally we prefer to have the lines organized like the following:
  Bug title
  Bug link

  Detailed description

Could you please add the bug title before the link?

If you add a new test, we should have a line like:
  Test: fast/files/blob-slice-overflow.html
It should be added by prepare-ChangeLog automatically.

> LayoutTests/fast/files/blob-slice-overflow.html:14
> +var i = 0;
> +for (; i < 2000; ++i) text += 'A';

Can we move "var i = 0" to the for statement since i is not referred outside
the for loop?

> LayoutTests/ChangeLog:5
> +	   https://bugs.webkit.org/show_bug.cgi?id=47382

Please add bug title before the bug link.