[webkit-reviews] review denied: [Bug 14550] Non-layout style change does not update nested first-letter : [Attachment 69764] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 10:56:47 PDT 2010


Dave Hyatt <hyatt at apple.com> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 14550: Non-layout style change does not update nested first-letter
https://bugs.webkit.org/show_bug.cgi?id=14550

Attachment 69764: Patch
https://bugs.webkit.org/attachment.cgi?id=69764&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
My one concern here is if updateFirstLetter() causes the RenderTextFragment to
be destroyed (e.g., if the display type of first-letter changes from inline to
block).  I'd like to see a test for that so that we know we won't crash with
this patch in place.


More information about the webkit-reviews mailing list