[webkit-reviews] review granted: [Bug 34539] Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a stub for NPN_GetAuthenticationInfo : [Attachment 70193] Implement NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo [Final #5]...

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Dawit A. <adawit at kde.org>'s
request for review:
Bug 34539: Implement NPN_GetValueForURL and NPN_SetValueForURL and provide a
stub for NPN_GetAuthenticationInfo
https://bugs.webkit.org/show_bug.cgi?id=34539

Attachment 70193: Implement NPN_GetValueForURL and NPN_SetValueForURL and
NPN_GetAuthenticationInfo [Final #5]...
https://bugs.webkit.org/attachment.cgi?id=70193&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70193&action=review

Looks good otherwise!

> WebCore/platform/network/ProxyServer.h:71
> +Vector<ProxyServer> proxyServersForURL(const KURL&, const NetworkingContext*
context = 0);

I think it's a bit weird to make this default to null. Couldn't we instead
always require the argument to be passed?