[webkit-reviews] review granted: [Bug 47405] Refactor HTMLInputElement: Move typeMismatch(), valueMissing(), isRequiredFormControl(), and recalcWillValidate() : [Attachment 70221] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 47405: Refactor HTMLInputElement: Move typeMismatch(), valueMissing(),
isRequiredFormControl(), and recalcWillValidate()
https://bugs.webkit.org/show_bug.cgi?id=47405

Attachment 70221: Patch
https://bugs.webkit.org/attachment.cgi?id=70221&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70221&action=review

This looks better and better. I am very happy with this design.

> WebCore/html/HTMLInputElement.cpp:2020
> +    return m_inputType->supportsValidation() &&
HTMLFormControlElementWithState::recalcWillValidate();

OMG, This is so much easier to understand.

> WebCore/html/NumberInputType.h:48
> +    virtual bool typeMismatchForCandidate(const String&) const;
> +    virtual bool typeMismatchForCurrentValue() const;

I wonder if out of these two, there's just one virtual function,
typeMismatchFor(const String&), and HTMLInputType::typeMismatch() just calls
it?