[webkit-reviews] review granted: [Bug 47322] Crash on reload when CSS property 'content' has malformed URL. : [Attachment 70205] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 09:10:45 PDT 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has granted James Kozianski
<koz at chromium.org>'s request for review:
Bug 47322: Crash on reload when CSS property 'content' has malformed URL.
https://bugs.webkit.org/show_bug.cgi?id=47322

Attachment 70205: Patch
https://bugs.webkit.org/attachment.cgi?id=70205&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70205&action=review

r=me but please fix the test.

> LayoutTests/fast/css-generated-content/malformed-url.html:3
> +<div style="content:url(//%);"></div>	      <!-- Crashes Chromium -->

> +<div style="content:url(http://|server|/);"></div> <!-- Crashes debug WebKit
-->

Please remove the comments, since once this bug is fixed, they will no longer
be correct.

I don't like the strategy of navigating to another page to finish the test.
Please change this to run the test in an iframe.


More information about the webkit-reviews mailing list